Fix the encoding in the convert-hf-to-gguf-update.py file #8040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Galunid
approved these changes
Jun 20, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made as a follow up of a request made by another contributer to split my last PR into two separate PRs.
In this PR the
convert-hf-to-gguf-update.pywas updated to useencoding="utf-8"when reading and writing onconvert-hf-to-gguf.pybecause some characters kept breaking the execution of theconvert-hf-to-gguf-update.py(mostly hexadecimal characters that weren't recognized under windows default encoding) like the rocket emojis "🚀"