Fixed json strings grammar by blacklisting character control set #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll let run my "bruteforce" script for some time before marking it as ready for review (Generating jsons in a loop and trying to parse it in python) |
|
Good to go this time ! |
cebtenzzre
approved these changes
Mar 5, 2024
hazelnutcloud
pushed a commit
to hazelnutcloud/llama.cpp
that referenced
this pull request
Mar 10, 2024
* Prevent control characters from being served in json string * Prevent control characters from being served in json string (array)
jordankanter
pushed a commit
to jordankanter/llama.cpp
that referenced
this pull request
Mar 13, 2024
* Prevent control characters from being served in json string * Prevent control characters from being served in json string (array)
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
* Prevent control characters from being served in json string * Prevent control characters from being served in json string (array)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time it works.
At the first try I tried to disable only \n, which made appear quickly \r, and after brutforcing jsons for 30mins It gave me an error on a
0x1Bcharacter.For curious people, I was using mistral 7b 0.2 instruct.
Initial incomplete fix : #5885