cmake: refined conditions for math library linking on windows #11312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
Can you suggest a way to reproduce the issue that you are seeing? Does it happen with a specific version of mingw? I have mingw installed alongside MSVC, and the github runners do as well, so at least it doesn't happen in every case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some problems when building llama.cpp on windows (for x64 and arm64) on a system where MSVC (with clang) and mingw are installed at the same time.
It seems to me that the condition for adding MATH_LIBRARY to the build is not quite correct. MATH_LIBRARY should not be added if
An important addition - in case clang is used in the MSVC pipeline, we should not add the library (condition
CMAKE_CXX_SIMULATE_ID STREQUAL "MSVC"was added for this). At the same time, when building with mingw, the library can be added.I think this would also be a solution to this issue (if it hadn't closed).