Align structures for 64bit, reorder params and ignore error-warn for Clang 19 #11291
+37
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
GermanAizek
force-pushed
the
optimize
branch
2 times, most recently
from
e5382ff to
9a2380e
Compare
|
@ggerganov done for code review. |
ggerganov
reviewed
Jan 20, 2025
Comment on lines
+20
to
+25
| // disable C++11 deprecation warning non-constant-expression cannot be narrowed | ||
| #if defined(__clang__) | ||
| # pragma clang diagnostic push | ||
| # pragma clang diagnostic ignored "-Wc++11-narrowing" | ||
| #endif | ||
|
|
There was a problem hiding this comment.
What the warnings that are ignored by this?
There was a problem hiding this comment.
The strangest thing was that there was an error initially, but now it's gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again.
Most processors and OS are 64-bit, alignment will not be superfluous, I also fixed compilation error on Clang 19.
All structures are reduced by 8 bytes.