Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : (tests) don't use thread for capturing stdout/stderr, bump openai client library #10568

Merged
merged 3 commits into from
Nov 28, 2024
Merged

server : (tests) don't use thread for capturing stdout/stderr, bump openai client library #10568

merged 3 commits into from
Nov 28, 2024

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Nov 28, 2024

Fix #10416 (comment)

@ngxson ngxson requested a review from slaren November 28, 2024 15:48
@github-actions github-actions bot added examples python python script changes server labels Nov 28, 2024
@ngxson
Copy link
Collaborator Author

ngxson commented Nov 28, 2024 •
edited
Loading

Hmm, annoyingly, the upstream openai pip package is broken.

Ref: openai/openai-python#1903

cc @ggerganov

@ngxson ngxson changed the title server : (tests) don't use thread for capturing stdout/stderr server : (tests) don't use thread for capturing stdout/stderr, bump openai client library Nov 28, 2024
@ngxson
Copy link
Collaborator Author

ngxson commented Nov 28, 2024

Should be good now, openai package version 1.55.3 fixed the issue

@ngxson ngxson merged commit 6c59567 into ggerganov:master Nov 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

@ggerganov ggerganov Awaiting requested review from ggerganov

Assignees
No one assigned
Labels
examples python python script changes server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngxson @slaren