Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locking of device lifetime tracker on resource drop #984

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix locking of device lifetime tracker on resource drop #984

merged 1 commit into from
Oct 13, 2020

Conversation

kvark
Copy link
Member

@kvark kvark commented Oct 13, 2020

Connections
Fixes the player hang in #983

Description
It turns out the current type-level protection from locking device's lifetime tracker is not working properly. TODO is left.

Testing
Tested on the trace from #983

@kvark
Copy link
Member Author

kvark commented Oct 13, 2020

bors r+

monocodus[bot]
monocodus bot suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 0 warnings, 1 errors.

@bors
Copy link
Contributor

bors bot commented Oct 13, 2020

Build succeeded:

@bors bors bot merged commit 0f16fb0 into gfx-rs:master Oct 13, 2020
@kvark kvark deleted the device-lock branch October 13, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monocodus monocodus[bot] monocodus[bot] requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kvark