Remove Peek-Poke #739

kvark · 2020-06-19T20:26:09Z

Connections
Related to #738
Related to djg/peek-poke#10

Description
As of #726 , the buffers have a minimum binding size that has to include the shader struct size. It, therefore, can't be zero.
We can remove the hacks we had previously and switch fully to the idiomatic Option<NonZeroU64>.

Peek-poke doesn't NonZeroU64 and friends, so this made me reconsider the user of it entirely. Today, render bundles as well as the Player already represent command streams using a much rustier method. I tried to move everything to this method now, and I think this is going to work much better, and safer.

Testing
wgpu-rs works - gfx-rs/wgpu-rs#396

There was a lot of highly unsafe use of serialization based on peek-poke that we weren't entirely happy with. It's replaced by just serializing the passes now. Also, switch BufferSize to Option<NonZero>.

kvark · 2020-06-20T14:29:15Z

@cwfitzgerald this is ready for reviewing! Do you think you can rebase on top of this?

cwfitzgerald

LVGTM! This is amazing, so much unsafe code, vanished into the ether!
bors r+

bors · 2020-06-20T17:58:03Z

Build succeeded:

396: Update wgpu without peek-poke r=cwfitzgerald a=kvark Depends on gfx-rs/wgpu#739 Everything works, however I think it's worth changing the render pass color/depth/stencil descriptors to be more rusty, e.g. ```rust struct ColorAttachmentDescriptor { attachment: &'a TextureView, resolve_target: Option<&'a TextureView>, clear_color: Option<Color>, store_result: bool, } enum DepthStencilChannel<T> { ReadOnly, Mutable { clear_value: Option<T>, store_result: bool }, } struct DepthStencilAttachmentDescriptor { } ``` This would also involve wgpu-type/wgpu-core changes, but can be done as a follow-up (don't want to block on them). There is a value in doing it in this PR, so that end users don't get multiple disruptions, but we need to find a proper shape first. Co-authored-by: Dzmitry Malyshau <[email protected]>

396: Update wgpu without peek-poke r=cwfitzgerald a=kvark Depends on gfx-rs#739 Everything works, however I think it's worth changing the render pass color/depth/stencil descriptors to be more rusty, e.g. ```rust struct ColorAttachmentDescriptor { attachment: &'a TextureView, resolve_target: Option<&'a TextureView>, clear_color: Option<Color>, store_result: bool, } enum DepthStencilChannel<T> { ReadOnly, Mutable { clear_value: Option<T>, store_result: bool }, } struct DepthStencilAttachmentDescriptor { } ``` This would also involve wgpu-type/wgpu-core changes, but can be done as a follow-up (don't want to block on them). There is a value in doing it in this PR, so that end users don't get multiple disruptions, but we need to find a proper shape first. Co-authored-by: Dzmitry Malyshau <[email protected]>

monocodus bot approved these changes Jun 19, 2020

View reviewed changes

kvark force-pushed the size branch from 3f21df3 to 0fba470 Compare June 20, 2020 02:24