Implement Mappable Primary Buffers Extension #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
DethRaid
approved these changes
Jun 8, 2020
kvark
reviewed
Jun 9, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 9, 2020
708: Implement Mappable Primary Buffers Extension r=kvark a=cwfitzgerald **Connections** #675 made `MAP_WRITE | STORAGE` on buffers not possible. This extension re-enables it. **Description** UMA systems rejoice everywhere. **Testing** Hopefully it didn't break since it was usable a week or so ago, so this shouldn't need testing... **Review Notes** The name could be changed, particularly if primary has a certain meaning wrt buffers. It just seemed a reasonable description. Knowing my luck, I got the bitflags call wrong... Co-authored-by: Connor Fitzgerald <[email protected]>
|
bors r- |
|
Canceled. |
|
One thing is missing: where and when is this actually going to be exposed? In the PR as is, the extension is not exposed at all, so it's not usable. |
|
All this changes is the valid usages for buffers so the interface doesn't change at all. This worked fine before the assert was added, so]disabling the assert makes it work again. |
|
Well, yes and no. The assert is gone when the new extension is enabled. But for it to be enabled, the adapter needs to expose it as available. I don't see where it exposes it. |
cwfitzgerald
force-pushed
the
mappable-primary-buffers
branch
from
ab4eea4 to
525c44f
Compare
|
D'oh, of course, fixed! |
cwfitzgerald
force-pushed
the
mappable-primary-buffers
branch
from
525c44f to
4258c60
Compare
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
…s#708) * Add a note about references and pointers to Expression::Load * Formatting * Remove comma * Clearer English
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#675 made
MAP_WRITE | STORAGEon buffers not possible. This extension re-enables it.Description
UMA systems rejoice everywhere.
Testing
Hopefully it didn't break since it was usable a week or so ago, so this shouldn't need testing...
Review Notes
The name could be changed, particularly if primary has a certain meaning wrt buffers. It just seemed a reasonable description.
Knowing my luck, I got the bitflags call wrong...