Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Most objects in wgpu are now Clone" to highlight section #6930

Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 16, 2025

This is kinda big and we didn't mention it in the changelog :O

@cwfitzgerald cwfitzgerald merged commit d5d5157 into gfx-rs:trunk Jan 16, 2025
28 checks passed
@brody4hire
Copy link
Contributor

brody4hire commented Jan 16, 2025

Just noting as an outsider that this was for PR #6665 (landed in 03ff99e) , which was part of recent release 24.0.0 (not for "unreleased").

To be fair I am one to forget this kind of thing all the time :)


P.S. I think I was not 100% clear that these changelog updates are retro-actively added to the section under release 24.0.0. Thanks to Fitzgerald & Wumpf for clarifying this info below.

@cwfitzgerald
Copy link
Member

Ooop, thanks for pointing that out!

@Wumpf
Copy link
Member Author

Wumpf commented Jan 16, 2025

Yes, I also put it retro-actively under 24.0.0, not under "unreleased".
Or am I misunderstanding something?

(I also added it to the 24 gh release)

@Wumpf Wumpf deleted the missing-changelog-entry-on-clone branch January 16, 2025 19:02
@cwfitzgerald
Copy link
Member

Oh I misinterpreted what @brodycj said, yeah we were realizing we forgot something in the changelog for 24, so were adding it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants