Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wgpu-info Default to Static-DXC as Well #6782

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

cwfitzgerald
Copy link
Member

Fixes #6730 not affecting the chosen feature set.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner December 18, 2024 19:33
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) December 18, 2024 19:48
@cwfitzgerald cwfitzgerald merged commit be07f41 into gfx-rs:trunk Dec 18, 2024
27 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/fix-tests-use-static-dxc branch December 18, 2024 20:25
@Wumpf
Copy link
Member

Wumpf commented Jan 2, 2025

This fails linking for me when actually enabling dx12 on wgpu-info ... which we didn't so far which is quite bad as well :/

  = note: lld-link: error: undefined symbol: __std_replace_8␍
          >>> referenced by libmach_dxcompiler_rs-3cf2c3c8766a8717.rlib(LoopUnroll.obj):(bool __cdecl llvm::UnrollLoop(class llvm::Loop *, unsigned int, unsigned int, bool, bool, unsigned int, class llvm::LoopInfo *, class llvm::Pass *, class llvm::LPPassManager *, class llvm::AssumptionCache *))␍

@cwfitzgerald
Copy link
Member Author

This is #6655 - you need to update your visual studio installation, but an up-to-date mach-dxcompiler-rs should have an error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants