-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage to TextureViewDescriptor #6755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that hal::TextureUses are generated independently of any TextureUsage: wgpu/wgpu-core/src/device/resource.rs Line 1251 in 89a8867
I think we just need to do validation against desc.usage when doing stuff on TextureView. |
sagudev
force-pushed
the
TextureViewDesc-usage
branch
from
December 17, 2024 06:37
abd625c
to
36f7f7d
Compare
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 17, 2024
Signed-off-by: sagudev <[email protected]>
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 17, 2024
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "bencher": false, "wpt_args": "_webgpu"}]}
|
teoxoy
requested changes
Dec 17, 2024
teoxoy
reviewed
Dec 17, 2024
cwfitzgerald
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will let @teoxoy give final word before merging.
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
TextureViewDesc-usage
branch
from
December 18, 2024 06:04
434955d
to
993bb36
Compare
teoxoy
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spec says that we should obtain usage via TextureViewDescriptor: https://www.w3.org/TR/webgpu/#dom-gputextureviewdescriptor-usage, although by default it's is the same as in parent.
Testing
CTS run in servo: #6755 (comment)
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.