fix: Read environment variable configs in hello_triangle example #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Dec 11, 2024
fryeb
force-pushed
the
fix/configure-hello-triangle
branch
from
69b4842 to
d71abfa
Compare
|
I've removed the accidentally-queued lock file stuff. Might be worth adding another utils method for getting the whole instance descriptor, but we'll see. Not worth blocking this quick fix imho |
|
I had a spare couple of minutes so I factored the whole thing into the utilities package, hopefully that makes the examples a little more succinct. |
auto-merge was automatically disabled
December 13, 2024 00:36
Head branch was pushed to by a user without write access
|
Apologies for re-requesting again. Just had to fix the clippy error |
|
No worries! |
kentslaney
pushed a commit
to kentslaney/wgpu
that referenced
this pull request
Dec 16, 2024
…-rs#6698) * fix: Read environment variable configs in hello_triangle example * refactor: Add util method for creating entire instance descriptor from env * fix: Fix clippy error/warning about "unneeded `return` statement"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
The hello_triangle doesn't support switching backends, leading to confusing errors like this one: #4247
Description
This adds support for the WGPU_* environment variables to the hello_triangle example, so that backend-specific issues can more quickly be narrowed down and fixes.
Testing
I've tested this manually, not sure if there is a better procedure for automatically testing these things
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.