Allow CAMetalLayer images to be used as storage textures
#6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do all of the formats support this? |
|
I tested all formats supported by my system and all of them worked:
And all worked when adjusting the storage format of the storage texture binding in the compute shader. |
|
Looking at https://developer.apple.com/metal/Metal-Feature-Set-Tables.pdf I think this should work but I'm not too versed in the surface code. @cwfitzgerald do you see any issue with adding these usage flags? |
cwfitzgerald
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Problem: I want to use swap chain images in compute shaders, but I cannot do this since the Metal backend does not report the storage usage flags to be supported. When adding the necessary flags, I am able to write to the swap chain images from a compute shader.
The Metal backend already sets framebufferOnly only if the usage is equivalent to
COLOR_TARGET, see here, so no further changes seem to be necessary.Testing
Explain how this change is tested.
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.