Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: [spv-front] Support for OpAtomicCompareExchange, fixes #6296 #6590

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

schell
Copy link
Contributor

@schell schell commented Nov 22, 2024

Connections

Description
Adds support for parsing and executing OpAtomicCompareExchange in the SPIR-V frontend.
This concludes the work to support atomics in the SPIR-V frontend, excluding test clean-up.

Testing

RUST_LOG=trace cargo watch -x 'test -p naga --features spv-in,wgsl-in,wgsl-out -- --nocapture atomic_compare_exchange'

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@schell schell marked this pull request as ready for review November 23, 2024 23:28
@schell schell requested a review from a team as a code owner November 23, 2024 23:28
@schell schell changed the title feature: [spv-front] WIP Support for OpAtomicCompareExchange feature: [spv-front] Support for OpAtomicCompareExchange, fixes #6296 Nov 23, 2024
@schell schell force-pushed the feature/spirv-front-atomics-compare-exchange branch from bc2c9ab to 5d88eda Compare November 24, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant