-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we pick the right gpu card in the example backend #6557
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution! looks good to me!
ah but I think this will fail wasm ci because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this still needs special handling for wasm (and fix unused warnings) - that checklist on the PR template is there for a reason ;-)
Thanks @Wumpf for pointing that out. Sorry about that. I've fixed wasm support by refactoring this logic out into a seperate function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries!
a little bit much c&p for my taste, but this will do just fine :)
Connections
fixes #6522
Description
This is my first time contributing to this project, so it may be that I'm doing something wrong. Essentially, we retain the old behavior if we use the environment variable to select our gpu. Otherwise we first try to match required features prior to selecting an adapter.
Testing
Just run the example as done before.
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.