-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging around surface creation #6511
base: trunk
Are you sure you want to change the base?
Conversation
…d is now `debug`, it being enabled is `info`
…questAdapterOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I remember @jimblandy mentioning a while back that having some of the adapter related logging in firefox (which filters out anything below info
and it's tricky to change because reasons) was important.
We should probably use the |
to be clear, I'd really prefer having those logs in debug :) (telling users to run a program with |
I see but we still need a way for these to show up at the info level or else they won't show up at all in Firefox. |
This comment was marked as resolved.
This comment was marked as resolved.
I've had the situation explained to me a bit more now 😅 At Mozilla, we're definitely going to want to understand how adapters got chosen or ignored, when something isn't working as expected. However, Firefox builds remove all logging below So we would want the adapter creation logging, and we'd want it done in some way or another that allows us to retain it in Firefox. Beyond that, I don't think we have strong opinions about what the logging should be. |
Yeah, I also definitely want to have these things in the log, which is why I added more in this PR .. just.. I want them on debug 😄 Anyways, that puts us into an uncomfortable spot though - using ## Log all API entry points at info instead of trace level.
api_log_info = [] So what we could do is to stretch the meaning a bit: ## Log all API entry points at info instead of trace level.
## Also, promotes certain debug log calls to info.
api_log_info = [] and then go with that meaning for the calls I demoted here. That way we can have the cake and eat it too without further over-engineering this. Thoughts? |
Connections
INFO
-level logging is too verbose #3206Description
request_adapter
is more talkative about its decisions in debug log messages nowRequestAdapterOptions::compatible_surface
, this duplicates what we already write on wgpu's request adapter, but better to request this weirdness where it's needed!Testing
ran hello_triangle and looked at things
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.