Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WGSL: add base support for requires that reports nice errors #6437

Merged
merged 2 commits into from
Oct 23, 2024
Merged

WGSL: add base support for requires that reports nice errors #6437

merged 2 commits into from
Oct 23, 2024

Conversation

ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Oct 22, 2024 •
edited
Loading

Connections

Description

-

Testing

  • I've manually tested this to my satisfaction.
  • Tests will be added in a follow-up PR for the most impactful coverage. Exhaustive coverage is left for WebGPU CTS.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@ErichDonGubler ErichDonGubler self-assigned this Oct 22, 2024
@ErichDonGubler ErichDonGubler added type: enhancement New feature or request naga Shader Translator lang: WGSL WebGPU Shading Language labels Oct 22, 2024
@ErichDonGubler ErichDonGubler force-pushed the erichdongubler/push-nxmwmormowll branch 2 times, most recently from c029a21 to 499bddd Compare October 22, 2024 20:18
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 22, 2024
Draft
7 tasks
@ErichDonGubler ErichDonGubler mentioned this pull request Oct 22, 2024
Open
@ErichDonGubler ErichDonGubler changed the title WGSL: Parse requires directives WGSL: Add a skeleton for requires that reports nice errors Oct 22, 2024
@ErichDonGubler ErichDonGubler changed the title WGSL: Add a skeleton for requires that reports nice errors WGSL: add base support for requires that reports nice errors Oct 22, 2024
@ErichDonGubler ErichDonGubler marked this pull request as ready for review October 23, 2024 02:14
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner October 23, 2024 02:14
teoxoy
teoxoy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ErichDonGubler ErichDonGubler merged commit 9730843 into gfx-rs:trunk Oct 23, 2024
27 checks passed
@ErichDonGubler ErichDonGubler deleted the erichdongubler/push-nxmwmormowll branch October 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
WebGPU for Firefox
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WGSL: Support the requires directive
2 participants
@ErichDonGubler @teoxoy