-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parking_lot dependency #6287
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Any version which does not contain Amanieu/parking_lot@cbab7b0. The error is that you try to invoke a non-const function in const context. |
This update is fine, one concern @ErichDonGubler just double checking we're good to force ff on parking_lot 0.12? |
Pretty sure we should be good; If it doesn't work, I'll be learning a lot as I effect a reversion! 🤪 |
This comment was marked as resolved.
This comment was marked as resolved.
(apologies for the noise earlier, should have read this more properly!) |
This comment was marked as resolved.
This comment was marked as resolved.
wgpu-hal does not compile with parking_lot versions that don't contain const Mutex::new.
5060613
to
88ee092
Compare
Connections
None
Description
wgpu-hal does not compile with parking_lot versions that don't contain const Mutex::new.
Testing
Not at all. I used the github web UI for this change.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.