Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parking_lot dependency #6287

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Update parking_lot dependency #6287

merged 1 commit into from
Sep 18, 2024

Conversation

mahkoh
Copy link
Contributor

@mahkoh mahkoh commented Sep 17, 2024

Connections

None

Description

wgpu-hal does not compile with parking_lot versions that don't contain const Mutex::new.

Testing

Not at all. I used the github web UI for this change.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@mahkoh mahkoh requested a review from a team as a code owner September 17, 2024 11:06
@Wumpf

This comment was marked as resolved.

@Wumpf Wumpf closed this Sep 17, 2024
@mahkoh

This comment was marked as resolved.

@Wumpf Wumpf reopened this Sep 17, 2024
@Wumpf

This comment was marked as resolved.

@mahkoh
Copy link
Contributor Author

mahkoh commented Sep 17, 2024

Can you provide more detail on which versions don't work out and what exact errors you're getting?

Any version which does not contain Amanieu/parking_lot@cbab7b0. The error is that you try to invoke a non-const function in const context.

@cwfitzgerald
Copy link
Member

This update is fine, one concern

@ErichDonGubler just double checking we're good to force ff on parking_lot 0.12?

@ErichDonGubler
Copy link
Member

Pretty sure we should be good; parking_lot_core's latest version is 0.9.9, which uses windows-targets 0.52, which Firefox has a fake force-upgrade crate for (see build/rust/windows-targets/Cargo.toml:3). CC @jimblandy and @teoxoy for 👀.

If it doesn't work, I'll be learning a lot as I effect a reversion! 🤪

@ErichDonGubler

This comment was marked as resolved.

@ErichDonGubler ErichDonGubler self-assigned this Sep 18, 2024
@ErichDonGubler ErichDonGubler added area: infrastructure Testing, building, coordinating issues area: ecosystem Help the connected projects grow and prosper labels Sep 18, 2024
@Wumpf
Copy link
Member

Wumpf commented Sep 18, 2024

(apologies for the noise earlier, should have read this more properly!)

@mahkoh

This comment was marked as resolved.

wgpu-hal does not compile with parking_lot versions that don't contain const Mutex::new.
@ErichDonGubler ErichDonGubler enabled auto-merge (squash) September 18, 2024 13:43
@ErichDonGubler ErichDonGubler merged commit ab9a78c into gfx-rs:trunk Sep 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ecosystem Help the connected projects grow and prosper area: infrastructure Testing, building, coordinating issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants