Update some docs containing OpenGL or GLSL references #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Sep 14, 2024
cwfitzgerald
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#2849
Description
While all examples listed in the issue did have a WGSL example first, and a GLSL example second, there were still a few references to (presumably) old names and OpenGL concepts in the docs.
I think it still makes sense to provide links to the OpenGL wiki in a few places, since the WGSL spec doesn't provide a lot of context. But I've now added explicit links to the OpenGL wiki in places where it was simply stated to read the OpenGL or Vulkan spec.
After this pr, #2849 could potentially be closed.
Testing
Grepped for "Vulkan" and "OpenGL" and it looks like the remaining mentions are relevant.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.