Decouple device and queue IDs #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devices and queues can have different lifetimes, we shouldn't assume that their IDs match.
teoxoy
force-pushed
the
decouple_device_and_queue_IDs
branch
from
923b8ab to
77afd06
Compare
nical
approved these changes
Aug 5, 2024
|
The gecko side will need to be adapted to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #5092.
Description
Devices and queues can have different lifetimes, we shouldn't assume that their IDs match.
I had to slightly refactor the
WaitIdleError::WrongSubmissionIndexerror because we don't store the queue ID internally.Testing
Added a test.