[wgpu-core] Make the StagingBuffer implementation more robust
#5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should have always unmapped the staging buffer as we are using it on the GPU after this point.
It's already documented that to unmap a buffer it has to have been mapped. Vulkan was the only backend that was returning an OOM on missing `Buffer.block` but `Buffer.map_buffer` already returns an error in this case.
teoxoy
force-pushed
the
refactor-staging-buffer
branch
from
07b250c to
4c2ee69
Compare
teoxoy
added a commit
to teoxoy/wgpu
that referenced
this pull request
Jul 17, 2024
The size of the given `data` might be less than the size of the staging buffer. This issue became apparent with the refactor in 6f16ea4 (gfx-rs#5946) since there is now an assert in `StagingBuffer.write()`. Ruffle ran into this in gfx-rs#3193 (comment).
cwfitzgerald
pushed a commit
that referenced
this pull request
Jul 17, 2024
The size of the given `data` might be less than the size of the staging buffer. This issue became apparent with the refactor in 6f16ea4 (#5946) since there is now an assert in `StagingBuffer.write()`. Ruffle ran into this in #3193 (comment).
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
StagingBufferimplementation more robust and uses of it more consistent.PR doesn't need to be squashed, each commit builds by itself.