Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal 3.0 and 3.1 detection #5497

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Add Metal 3.0 and 3.1 detection #5497

merged 2 commits into from
Apr 5, 2024

Conversation

atlv24
Copy link
Collaborator

@atlv24 atlv24 commented Apr 5, 2024

Connections
Originally for #5383, will be needed for image atomics on metal

Depends on gfx-rs/metal-rs#304

Description
Detect Metal 3.0 and 3.1 when its available

Testing
Not tested explicitly but works in the context of #5383

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@atlv24 atlv24 requested a review from a team as a code owner April 5, 2024 04:59
@atlv24 atlv24 requested a review from a team as a code owner April 5, 2024 05:15
@atlv24 atlv24 mentioned this pull request Apr 5, 2024
6 tasks
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teoxoy teoxoy merged commit 1c48a23 into gfx-rs:trunk Apr 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants