Implement Unorm10_10_10_2 VertexFormat #5477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McMackety
changed the title
|
@McMackety could you resolve the conflicts? |
|
@teoxoy just resolved them. |
teoxoy
requested changes
Apr 3, 2024
teoxoy
changed the title
Co-authored-by: Teodor Tanasoaia <[email protected]>
teoxoy
reviewed
Apr 3, 2024
teoxoy
reviewed
Apr 3, 2024
teoxoy
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
web-systo0.3.67since we are using unstable APIs #5224 being fixed, as that web-sys version is required, as such this PR does not have a complaint wgpu -> WebGPU backend. (Specifically, the timestamping functionality was disabled)Description
This PR implements the Unorm10_10_10_2 VertexFormat as well as implements the translations required to make it useable on all available backends.
Testing
I manually tested the changes and haven't found any issues, though still need to run it through the updated conformance tests. Additionally, it may be useful to add Unit Tests for this, although currently the different vertex formats are not tested.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown(Failed due to web-sys version)--target wasm32-unknown-emscripten(Failed due to web-sys version)cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.