Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nested Loops in GLSL #5311

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Fix Nested Loops in GLSL #5311

merged 1 commit into from
Feb 28, 2024

Conversation

cwfitzgerald
Copy link
Member

Closes #5246.

The fix worked as expected.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner February 27, 2024 20:30
teoxoy
teoxoy approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@teoxoy teoxoy merged commit 8129897 into gfx-rs:trunk Feb 28, 2024
27 checks passed
@cwfitzgerald cwfitzgerald added PR: needs back-porting PR with a fix that needs to land on crates and removed PR: needs back-porting PR with a fix that needs to land on crates labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index value issue in GLSL front nested loop
2 participants
@cwfitzgerald @teoxoy