Simplify the ID allocation in IdentityValues #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
force-pushed
the
simple-id-alloc
branch
from
e3d1621 to
1904be5
Compare
cwfitzgerald
requested changes
Feb 15, 2024
nical
force-pushed
the
simple-id-alloc
branch
from
674366f to
1d87b9a
Compare
cwfitzgerald
approved these changes
Feb 15, 2024
3 tasks
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 29, 2024
Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Addresses part of #5196
Description
Our Id allocation logic keeps track of all used IDs, grouped by epoch. There are two issues with that:
This PR switches to a very simple and fast logic for allocating IDs, which works under the assumption that we either always allocate IDs, or always provide them externally.
~Unfortunately right now this assumption breaks in one place in the tests, so we have to fix that.` Edit: False alert, it seems to work.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.