-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impl. const. eval. for yet more trivial component-wise numeric built-ins in WGSL #5098
Merged
teoxoy
merged 20 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:builtins-const-eval-2
Jan 30, 2024
Merged
Impl. const. eval. for yet more trivial component-wise numeric built-ins in WGSL #5098
teoxoy
merged 20 commits into
gfx-rs:trunk
from
erichdongubler-mozilla:builtins-const-eval-2
Jan 30, 2024
+318
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
c4df992
to
c9176fb
Compare
4 tasks
ErichDonGubler
commented
Jan 26, 2024
acdfc66
to
038b0d5
Compare
038b0d5
to
119a549
Compare
119a549
to
057f41f
Compare
Loading status checks…
…` impls.
7e78aca
to
9753478
Compare
teoxoy
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: correctness
We're behaving incorrectly
area: cts
Issues stemming from the WebGPU Conformance Test Suite
area: naga processing
Passes over IR in the middle
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Resolves many more of the now-trivial-to-implement built-ins, as an iteration over #4879.
Description
Describe what problem this is solving, and how it's solved.
See above.
Testing
Explain how this change is tested.
The current form of this PR depends on our snapshot test coverage for
naga
. I don't think it's complete; I'd be open to adding more coverage as part of this PR.Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.