Document Wayland specifics related to SurfaceTexture::present #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is largely based off the Vulkan and EGL specification's Wayland platforms. Signed-off-by: i509VCB <[email protected]>
23 tasks
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
approved these changes
Jan 21, 2024
cwfitzgerald
added a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Jan 21, 2024
…#5093) Co-authored-by: Connor Fitzgerald <[email protected]>
cwfitzgerald
removed
the
PR: needs back-porting
a1phyr
reviewed
Jan 22, 2024
| @@ -39,6 +39,10 @@ Bottom level categories: | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Documentation | |||
|
|
|||
| - Document Wayland specific behavior related to `SurfaceTexture::present`. By @i509VCB in [#5092](https://github.com/gfx-rs/wgpu/pull/5092). | |||
There was a problem hiding this comment.
The PR link is wrong here, it should be 5093.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
This is related to an issue wezterm had that was brought up on the wgpu matrix channel as a result of directly using wayland-client with wgpu. It wasn't very clear what SurfaceTexture::present did under the hood. Sure it's been like 6 months since that, but better late than never.
The documentation is largely based off the Vulkan and EGL specification's Wayland platforms.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.