Re-export public dependencies #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
re-export-public-dependencies
branch
from
b76e6c1 to
a3dfbe3
Compare
cwfitzgerald
force-pushed
the
re-export-public-dependencies
branch
from
a3dfbe3 to
f47675e
Compare
Wumpf
approved these changes
Jan 15, 2024
daxpedda
reviewed
Jan 15, 2024
|
I wonder if it's worth documenting the feature shorthands in the lib.rs file so the user knows what to expect and we don't need to rename all the shorthands |
I believe this would be an improvement in any case 👍. |
cwfitzgerald
force-pushed
the
re-export-public-dependencies
branch
from
f47675e to
3baede1
Compare
cwfitzgerald
force-pushed
the
re-export-public-dependencies
branch
from
3baede1 to
6032442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5054.
Useful enough to have, and doesn't clutter things too much.
This re-organizes our naga dependency a bit, notably that it's now properly optional on wasm, only enabled if you enable a feature that requires transpilation, or a direct mention in our public interface.