Convert Tests to Use Async Poll #5053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
async-tests
branch
3 times, most recently
from
2f31def to
8253e08
Compare
kpreid
reviewed
Jan 13, 2024
cwfitzgerald
force-pushed
the
async-tests
branch
from
8253e08 to
bdea60e
Compare
Wumpf
approved these changes
Jan 13, 2024
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of splitting up #5012 into reviewable parts.
In 5012,
poll(Wait)no longer works on WebGL. As such, we need to switch to an async method of polling the device. This PR stubs out the async poll and polling functions needed, while not actually changing the behavior at all.This is a fairly major part of 5012, and made the diff hard to read due to how sweeping the changes are. None of this, besides the stubbing, should be controversial.