Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bounds check in remove_abandoned #5024

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix a bounds check in remove_abandoned #5024

merged 2 commits into from
Jan 9, 2024

Conversation

nical
Copy link
Contributor

@nical nical commented Jan 9, 2024

Connections

May or may not be a fix for #5022 (I have not been able to reproduce so far).

Description

Fixes what looks like a classic off-by-one error comparing an index with a length.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.

@nical nical requested a review from a team as a code owner January 9, 2024 12:56
cwfitzgerald
cwfitzgerald approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big whoops

@cwfitzgerald cwfitzgerald merged commit 4400a58 into gfx-rs:trunk Jan 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nical @cwfitzgerald