backport #4695 [naga] Let constant evaluation handle Compose of Splat. #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When consuming a `Compose` expression that constructs a vector, flatten `Splat` subexpressions out into their components. Fixes gfx-rs#4581.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Backports #4695 to the wgpu 0.18 branch (naga 0.14).
Description
Nested wgsl vec creation (eg.
vec3<f32>(vec2<f32>(1.0), 0.0)) spits out vulkan validation errors. This backports the fix for it to naga 0.14 so that devs writing bevy shaders don't have to change shaders to avoid the validation error.Testing
Examples still seem to run, and it fixed the vulkan validation errors when using eg.
vec3<f32>(vec2<f32>(1.0), 0.0).Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.cargo xtask validate spvkept failing with[ERROR xtask::result] 'spirv-val' failed to run; exit code: Some(1)despite spirv-val being in my PATH on windows.CHANGELOG.md. See simple instructions inside file.Apparently
git cherry-pick --no-commitstrips the OG commit author, so I redid it and closed the other one.