Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arcanization changelog #4795

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Fix Arcanization changelog #4795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,24 +61,23 @@ Previously, `DeviceExt::create_texture_with_data` only allowed data to be provid

### Changes

- Arcanization of wgpu core resources:
Removed Token and LifeTime related management
Removed RefCount and MultiRefCount in favour of using only Arc internal reference count
Removing mut from resources and added instead internal members locks on demand or atomics operations
Resources now implement Drop and destroy stuff when last Arc resources is released
Resources hold an Arc in order to be able to implement Drop
Resources have an utility to retrieve the id of the resource itself
Remove all guards and just retrive the Arc needed on-demand to unlock registry of resources asap
Verify correct resources release when unused or not needed
Check Web and Metal compliation (thanks to @niklaskorz)
Fix tests on all platforms
Test a multithreaded scenario
Storage is now holding only user-land resources, but Arc is keeping refcount for resources
When user unregister a resource, it's not dropped if still in use due to refcount inside wgpu
IdentityManager is now unique and free is called on resource drop instead of storage unregister
Identity changes due to Arcanization and Registry being just the user reference
Added MemLeaks test and fixing mem leaks
By @gents83 in [#3626](https://github.com/gfx-rs/wgpu/pull/3626) and tnx also to @jimblandy, @nical, @Wumpf, @Elabajaba & @cwfitzgerald
- Arcanization of wgpu core resources: By @gents83 in [#3626](https://github.com/gfx-rs/wgpu/pull/3626) and thanks also to @jimblandy, @nical, @Wumpf, @Elabajaba & @cwfitzgerald
- Removed Token and LifeTime related management
- Removed RefCount and MultiRefCount in favour of using only Arc internal reference count
- Removing mut from resources and added instead internal members locks on demand or atomics operations
- Resources now implement Drop and destroy stuff when last Arc resources is released
- Resources hold an Arc in order to be able to implement Drop
- Resources have an utility to retrieve the id of the resource itself
- Remove all guards and just retrive the Arc needed on-demand to unlock registry of resources asap
- Verify correct resources release when unused or not needed
- Check Web and Metal compliation (thanks to @niklaskorz)
- Fix tests on all platforms
- Test a multithreaded scenario
- Storage is now holding only user-land resources, but Arc is keeping refcount for resources
- When user unregister a resource, it's not dropped if still in use due to refcount inside wgpu
- IdentityManager is now unique and free is called on resource drop instead of storage unregister
- Identity changes due to Arcanization and Registry being just the user reference
- Added MemLeaks test and fixing mem leaks

#### General

Expand Down
Loading