[naga] Exercise GLSL double-precision builtin functions, and fix the fallout. #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
naga-glsl-fix-double-builtins
branch
from
ee70980 to
d956464
Compare
ErichDonGubler
approved these changes
Nov 15, 2023
jimblandy
force-pushed
the
naga-glsl-fix-double-builtins
branch
from
6cf836d to
37d0553
Compare
The first argument of the `dot`, `reflect`, `distance`, and `ldexp` GLSL builtin functions may be either a float or a double, and thus the argument type registered by `inject_common_builtin` must depend on the `float_width` argument; it cannot simply be `Scalar::F32`. Introduced by gfx-rs#4673.
The second argument of the GLSL `ldexp` builtin is always a 32-bit integer or a vector of such, never a 64-bit integer. In `inject_common_builtin`, that argument's type should not be influenced by `float_width`. Fixes gfx-rs#4680.
When generating WGSL for an `Expression::Compose` constructing a matrix, consult `TypeInner::Matrix::width` when writing the type name in the construction expression, rather than just always writing `matNxM<f32>`. Fixes gfx-rs#4681.
jimblandy
force-pushed
the
naga-glsl-fix-double-builtins
branch
from
37d0553 to
9081501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise GLSL double-precision builtin functions, and fix the fallout.
[naga] New tests for GLSL double-precision builtin functions.
[naga wgsl-out] Correctly include width in matrix constructions.
When generating WGSL for an
Expression::Composeconstructing amatrix, consult
TypeInner::Matrix::widthwhen writing thetype name in the construction expression, rather than just always
writing
matNxM<f32>.Fixes WGSL backend writes
matNxM<f64>construction expressions incorrectly. #4681.[naga glsl-in] Fix type of double ldexp's second arg.
The second argument of the GLSL
ldexpbuiltin is always a 32-bitinteger or a vector of such, never a 64-bit integer. In
inject_common_builtin, that argument's type should not be influencedby
float_width.Fixes [naga glsl-in] double-precision ldexp overload expects a 64-bit integer argument #4680.
[naga glsl-in] Fix double overload for dot/reflect/distance/ldexp.
The first argument of the
dot,reflect,distance, andldexpGLSL builtin functions may be either a float or a double, and thus the
argument type registered by
inject_common_builtinmust depend on thefloat_widthargument; it cannot simply beScalar::F32.Introduced by [naga] Introduce
Scalartype to IR. #4673.Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.