[naga] Improve algorithm for Module compaction. #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify reachable function expressions, constant expressions, and types using a single pass over each arena, taking advantage of the fact that expressions and types may only refer to other entries that precede them within their arena. Only walking the statement tree still requires a worklist/recursion. In addition to presumably being faster, this change slightly reduces the number of non-comment lines of code in `src/compact`.
jimblandy
force-pushed
the
naga-stackless-compact
branch
from
ea35340 to
0b4be22
Compare
|
I noticed the prior PR changed the IR tests but this one doesn't. |
Yes, this is expected: this PR only improves the algorithm, but it doesn't yet apply it in any new places. The prior PR introduced a new compactor specific to the WGSL front end, and added uses of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify reachable function expressions, constant expressions, and types using a single pass over each arena, taking advantage of the fact that expressions and types may only refer to other entries that precede them within their arena. Only walking the statement tree still requires a worklist/recursion.
In addition to presumably being faster, this change slightly reduces the number of non-comment lines of code in
src/compact.Closes #4509.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.