Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VK_EXT_robustness2 only when not using an outdated intel iGPU driver #4602

Merged
merged 11 commits into from
Dec 7, 2023
Merged

Use VK_EXT_robustness2 only when not using an outdated intel iGPU driver #4602

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2769528
Push `VK_EXT_robustness2` to extensions when not using an outdated in…
TheoDulka Oct 28, 2023
7dbd10b
Add to changelog
TheoDulka Oct 28, 2023
08dbdb0
fmt
TheoDulka Oct 28, 2023
800be89
Added logging for notifying when the intel igpu is outdated, added is…
TheoDulka Oct 28, 2023
c0b01b3
Moved to a function
TheoDulka Oct 29, 2023
23d2d21
Now disabling the feature PhysicalDeviceRobustness2FeaturesEXT rather…
TheoDulka Oct 29, 2023
c6b4e52
Changelog update
TheoDulka Oct 29, 2023
7dd30c0
Merge branch 'trunk' into intel-igpu-VK_EXT_robustness2
TheoDulka Nov 25, 2023
cb74274
Moved the check into the intitialization of capabilities
TheoDulka Nov 25, 2023
5fde874
Apply teo's requests
TheoDulka Dec 7, 2023
105834c
Merge branch 'trunk' into intel-igpu-VK_EXT_robustness2
teoxoy Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ Bottom level categories:

## Unreleased

### Bug Fixes

#### Vulkan
- Push `VK_EXT_robustness2` to extensions only when not using an outdated intel iGPU driver. By @TheoDulka in [#4602](https://github.com/gfx-rs/wgpu/pull/4602).

For naga changelogs at or before v0.14.0. See [naga's changelog](naga/CHANGELOG.md).

## v0.18.0 (2023-10-25)
Expand All @@ -57,7 +62,7 @@ By @Zoxc in [#4248](https://github.com/gfx-rs/wgpu/pull/4248)
Timestamp queries are now supported on both Metal and Desktop OpenGL. On Apple chips on Metal, they only support timestamp queries in command buffers or in the renderpass descriptor,
they do not support them inside a pass.

Metal: By @Wumpf in [#4008](https://github.com/gfx-rs/wgpu/pull/4008)
Metal: By @Wumpf in [#4008](https://github.com/gfx-rs/wgpu/pull/4008)
OpenGL: By @Zoxc in [#4267](https://github.com/gfx-rs/wgpu/pull/4267)

### Render/Compute Pass Query Writes
Expand Down Expand Up @@ -180,7 +185,7 @@ let instance = wgpu::Instance::new(InstanceDescriptor {
});
```

`gles_minor_version`: By @PJB3005 in [#3998](https://github.com/gfx-rs/wgpu/pull/3998)
`gles_minor_version`: By @PJB3005 in [#3998](https://github.com/gfx-rs/wgpu/pull/3998)
`flags`: By @nical in [#4230](https://github.com/gfx-rs/wgpu/pull/4230)

### Many New Examples!
Expand Down Expand Up @@ -226,7 +231,7 @@ By @teoxoy in [#4185](https://github.com/gfx-rs/wgpu/pull/4185)
- Add trace-level logging for most entry points in wgpu-core By @nical in [4183](https://github.com/gfx-rs/wgpu/pull/4183)
- Add `Rgb10a2Uint` format. By @teoxoy in [4199](https://github.com/gfx-rs/wgpu/pull/4199)
- Validate that resources are used on the right device. By @nical in [4207](https://github.com/gfx-rs/wgpu/pull/4207)
- Expose instance flags.
- Expose instance flags.
- Add support for the bgra8unorm-storage feature. By @jinleili and @nical in [#4228](https://github.com/gfx-rs/wgpu/pull/4228)
- Calls to lost devices now return `DeviceError::Lost` instead of `DeviceError::Invalid`. By @bradwerth in [#4238]([https://github.com/gfx-rs/wgpu/pull/4238])
- Let the `"strict_asserts"` feature enable check that wgpu-core's lock-ordering tokens are unique per thread. By @jimblandy in [#4258]([https://github.com/gfx-rs/wgpu/pull/4258])
Expand Down
14 changes: 13 additions & 1 deletion wgpu-hal/src/vulkan/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,8 +669,20 @@ impl PhysicalDeviceCapabilities {
}

// Optional `VK_EXT_robustness2`
// Intel iGPUs with outdated drivers can break rendering if `VK_EXT_robustness2` is pushed.
// Driver version 31.0.101.2115 works, but there's probably an earlier functional version.
TheoDulka marked this conversation as resolved.
Show resolved Hide resolved
if self.supports_extension(vk::ExtRobustness2Fn::name()) {
extensions.push(vk::ExtRobustness2Fn::name());
const DRIVER_VERSION_INTEL_31_0_101: u32 = 0x194000;
const DRIVER_VERSION_INTEL_WORKING: u32 = DRIVER_VERSION_INTEL_31_0_101 + 2115;

let props = self.properties;
let is_intel_igpu_outdated = props.vendor_id == crate::auxil::db::intel::VENDOR
&& props.device_type == vk::PhysicalDeviceType::INTEGRATED_GPU
&& props.driver_version < DRIVER_VERSION_INTEL_WORKING;

if !is_intel_igpu_outdated {
TheoDulka marked this conversation as resolved.
Show resolved Hide resolved
extensions.push(vk::ExtRobustness2Fn::name());
}
}

// Require `VK_KHR_draw_indirect_count` if the associated feature was requested
Expand Down
Loading