vulkan: Log validation layer messages during instance creation/destruction #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exrook
force-pushed
the
instance_logging
branch
from
169fdfd to
0cbc531
Compare
exrook
force-pushed
the
instance_logging
branch
from
0cbc531 to
d4500bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
n/a
Description
We currently miss some potentially useful validation layer messages by only registering our message callback after the instance has been created, by additionally passing the callback to VkCreateInstance we can log messages that occur during instance creation and destruction.
Testing
covered by existing vulkan tests