Make buffer_map and buffer_unmap check for device validity, add tests. #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes buffer_unmap check for a valid device, and corrects buffer_map to return the appropriate error for an invalid device. Tests are added for both operations. It also adds device validity checks to device_maintain_ids and to the functions that get and set buffer sub data.
Wumpf
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
This patch makes buffer_unmap check for a valid device, and corrects buffer_map to return the appropriate error for an invalid device. It also adds device validity checks to device_maintain_ids and to the functions that get and set buffer sub data.
Testing
Tests are added in device.rs checking buffer map and unmap for device validity errors.