-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make StoreOp
an enum instead of a bool
#4147
Conversation
f37fc77
to
abc47cd
Compare
abc47cd
to
43e5991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments, like the api change!
Co-authored-by: Connor Fitzgerald <[email protected]>
Co-authored-by: Connor Fitzgerald <[email protected]>
Co-authored-by: Connor Fitzgerald <[email protected]>
Co-authored-by: Connor Fitzgerald <[email protected]>
Thanks for all the comment improvements and keeping the bar for documentation high! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you miss a push, a couple resolved things are still unaddressed
eh, yeah I managed to push to the wrong remote 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Connor Fitzgerald <[email protected]>
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Description
wgpu::Operations::store
used to be an underdocumented boolean value,causing missunderstandings of the effect of setting it to
false
.The API now resembles WebGPU which distinguishes
store
anddiscard
,see WebGPU spec on GPUStoreOp.
Opted to put this text into the changelog under
Major Changes
since it breaks like every single use ;-)