Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deno and spec #4143

Merged
merged 10 commits into from
Oct 4, 2023
Merged

update deno and spec #4143

merged 10 commits into from
Oct 4, 2023

Conversation

crowlKats
Copy link
Collaborator

@crowlKats crowlKats commented Sep 15, 2023

Updated #2170

Copy link

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would recommend avoiding the #[serde] return value for WebGpuResult by reworking the APIs to make use of Result instead which will perform much better. For now, looks great!

rust-toolchain Outdated Show resolved Hide resolved
crowlKats and others added 3 commits September 16, 2023 07:58
@crowlKats crowlKats marked this pull request as ready for review September 21, 2023 07:29
@crowlKats crowlKats requested a review from a team September 21, 2023 07:29
@crowlKats crowlKats requested a review from a team as a code owner September 21, 2023 07:29
@cwfitzgerald
Copy link
Member

cwfitzgerald commented Sep 21, 2023

So thinking about it, dealing with the MSRV bump should be done the following way:

  • Up the rust toolchain file to what deno needs (already done)
  • Add a CI job for windows/mac/linux which only builds wgpu-core (and dependencies) which is built with 1.65. This will ensure we don't break firefox. It also doesn't need to run clippy, just cargo check.
  • Document mismatched MSRV.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes for bookkeeping purposes.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks fine, just need to address this first.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cwfitzgerald
Copy link
Member

Seems to have broken the player.

@crowlKats
Copy link
Collaborator Author

@cwfitzgerald I fixed it; problem was the RON for one of the tests because I added rename_all=camelCase, though now for one struct, the RON looks off in files since its the only thing with camelCase. Is this a problem? Else, I can just rename the serialize and leave deserialize to normal if preffered

@cwfitzgerald
Copy link
Member

That's fine, those Ron aren't a big deal.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeet

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) October 4, 2023 04:20
@cwfitzgerald cwfitzgerald merged commit d0a7f46 into gfx-rs:trunk Oct 4, 2023
23 checks passed
@crowlKats crowlKats deleted the update-deno branch October 4, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants