-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deno and spec #4143
update deno and spec #4143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would recommend avoiding the #[serde] return value for WebGpuResult by reworking the APIs to make use of Result instead which will perform much better. For now, looks great!
Co-authored-by: Connor Fitzgerald <[email protected]>
So thinking about it, dealing with the MSRV bump should be done the following way:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as request changes for bookkeeping purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks fine, just need to address this first.
Seems to have broken the player. |
@cwfitzgerald I fixed it; problem was the RON for one of the tests because I added rename_all=camelCase, though now for one struct, the RON looks off in files since its the only thing with camelCase. Is this a problem? Else, I can just rename the serialize and leave deserialize to normal if preffered |
That's fine, those Ron aren't a big deal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeet
Updated #2170