-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details to InstanceError
and CreateSurfaceError
.
#4066
Conversation
This will allow developers, particularly those in communication with users with hardware they don't own, to diagnose “why won't this work on my machine” better, without needing to obtain logs in addition to the error value. Note that this is a semver-breaking change because `InstanceError` and `CreateSurfaceError` no longer implement `PartialEq`. This could be avoided by pointer comparison of the internal `Arc`, but I think it is more typical Rust to not implement `PartialEq` for error types unless there is a strong motivation to and their contents are tightly controlled.
This PR is in principle ready to merge, but I am hoping to get around to writing tests for the |
I've added a test for |
That |
Ping? This should be ready to go now. Also, I have belatedly realized that I want to do exactly the same thing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful stuff!
Co-authored-by: Connor Fitzgerald <[email protected]>
Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Followup to #3052.
Description
This will allow developers, particularly those in communication with users with hardware they don't own, to diagnose “why won't this work on my machine” better, without needing to obtain logs in addition to the error value.
Note that this is a semver-breaking change because
InstanceError
andCreateSurfaceError
no longer implementPartialEq
. This could be avoided by pointer comparison of the internalArc
, but I think it is more typical Rust to not implementPartialEq
for error types unless there is a strong motivation to and their contents are tightly controlled.Testing
Ran
cargo nextest run
; CI will check other platforms.