[vulkan] Don't bother to free command buffers before destroying the pool. #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
vk-destroy-command-pool-is-enough
branch
from
a3071ae to
deeecc7
Compare
|
Please check my understanding of Vulkan, but the spec does say:
|
jimblandy
changed the title
Calling `vkDestroyCommandPool` automatically frees all command buffers allocated from that pool, so there is no need for `Device::destroy_command_encoder` to explicitly call `vkFreeCommandBuffers` on the `CommandEncoder`'s `free` and `discarded` lists.
jimblandy
force-pushed
the
vk-destroy-command-pool-is-enough
branch
from
deeecc7 to
f1ca502
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
vkDestroyCommandPoolautomatically frees all command buffers allocated from that pool, so there is no need forDevice::destroy_command_encoderto explicitly callvkFreeCommandBufferson theCommandEncoder'sfreeanddiscardedlists.Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.