Add validation in accordance with WebGPU setViewport
valid usage fo…
#4058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r
x
,y
andthis.[[attachment_size]]
.x
andy
must not be negative, and the rect must be contained in the render target.Checklist
cargo clippy
.cargo clippy --target wasm32-unknown-unknown
if applicable.Done just in case, with --feature gles.
Description
For
wgpu::RenderPass::set_viewport
, it was possible to use values such that:x
and/ory
is negativeboth of which are in violation of the valid usage defined for
setViewport
in the WebGPU spec:This PR renames
RenderCommandError::InvalidViewportDimension
toInvalidViewportRect
and adds render target extent to it, in the same spirit asInvalidScissorRect
(which has similar valid usage regarding render target extent).Testing
Tested locally.