[vk] Don't request portability enumeration without the extension. #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
portability-enumeration-needs-extension
branch
from
0c1fbce to
b12f69b
Compare
jimblandy
force-pushed
the
portability-enumeration-needs-extension
branch
2 times, most recently
from
b67f491 to
159d0f7
Compare
Use the `ash` crate's definition of `vk::InstanceCreateFlags::ENUMERATE_PORTABILITY_KHR` in `wgpu_hal::vulkan::Instance::init`, rather than re-declaring it locally ourselves.
VUID-VkInstanceCreateInfo-flags-06559 forbids us from passing `vk::InstanceCreateFlags::ENUMERATE_PORTABILITY_KHR` unless we actually found and requested the "VK_KHR_portability_enumeration" extension. Fixes gfx-rs#4004.
jimblandy
force-pushed
the
portability-enumeration-needs-extension
branch
from
159d0f7 to
49cc50e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VUID-VkInstanceCreateInfo-flags-06559 forbids us from passing
vk::InstanceCreateFlags::ENUMERATE_PORTABILITY_KHRunless we actually found and requested the "VK_KHR_portability_enumeration" layer.Fixes #4004.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Testing
This is covered by
wgpu-test::wgpu-tests encoder::drop_encoder.