Metal encoder & pass timestamp support #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
Aug 19, 2023
|
Pulling this out of draft - @Wumpf can you rebase and then let's land this thing. |
(this path is never hit on M1 for instance!)
Wumpf
force-pushed
the
metal-encoder-timestamps
branch
from
37458cb to
c1f5117
Compare
bradwerth
pushed a commit
to bradwerth/wgpu
that referenced
this pull request
Sep 19, 2023
Implements timer queries via write_timestamp on Metal for encoders (whenever timer queries are available) and passes (for Intel/AMD GPUs, where we should advertise TIMESTAMP_QUERY_INSIDE_PASSES now). Due to some bugs in Metal this was a lot harder than expected. I believe the solution is close to optimal with the current restrictions in place. For details see code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
Implements timer queries via
write_timestampon Metal for encoders (whenever timer queries are available) and passes (for Intel/AMD GPUs, where we should advertiseTIMESTAMP_QUERY_INSIDE_PASSESnow).Due to some bugs in Metal this was a lot harder than expected. I believe the solution is close to optimal with the current restrictions in place. For details see code comments.
Testing
Tested on an Apple Silicon device - this always goes a slow path and does not have
TIMESTAMP_QUERY_INSIDE_PASSESavailable.TODO: Test on AMD or Intel device where we have
TIMESTAMP_QUERY_INSIDE_PASSESand can go the fast & simple path.