Update max_bindings_per_bind_group default to 1000
#3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ErichDonGubler
force-pushed
the
max_bindings_per_bind_group-to-1000
branch
2 times, most recently
from
c2d140a to
9ade5c8
Compare
Both default `Limits` and the Vulkan backend use 640 as a hard-coded limit value, but the spec. was [updated](gpuweb/gpuweb#3864) to use 1000 instead.
ErichDonGubler
force-pushed
the
max_bindings_per_bind_group-to-1000
branch
from
9ade5c8 to
a5b6ba3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
which is testing against WebGPU CTS.
Description
Describe what problem this is solving, and how it's solved.
Both default
Limitsand the Vulkan backend use 640 as a hard-coded limit value, but the spec. was updated to use 1000 instead.Testing
Explain how this change is tested.