Migrate to nv-flip for image comparison #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
force-pushed
the
integrate-flip
branch
3 times, most recently
from
7488aba to
c81e527
Compare
3 tasks
cwfitzgerald
force-pushed
the
integrate-flip
branch
from
c81e527 to
a6c6ad7
Compare
3 tasks
cwfitzgerald
force-pushed
the
integrate-flip
branch
from
07dffad to
b3cee92
Compare
cwfitzgerald
force-pushed
the
integrate-flip
branch
from
b3cee92 to
f4e997b
Compare
cwfitzgerald
force-pushed
the
integrate-flip
branch
from
f41c8b9 to
1ef77e0
Compare
cwfitzgerald
force-pushed
the
integrate-flip
branch
from
1ef77e0 to
e7df29e
Compare
3 tasks
nical
reviewed
Jun 7, 2023
There was a problem hiding this comment.
Looks good overall. What color space is nvflip expecting the data to be in? It should be documented in the nv-flip crate and we should make sure the tests actually produce pixels in the right color space otherwise we are only giving the illusion of having a principled error metric.
|
Filed the color space info here: gfx-rs/nv-flip-rs#1 |
teoxoy
reviewed
Jun 8, 2023
|
@cwfitzgerald there seems to be an unexpected test pass 👀 |
|
Yeah, that was #3809 landing - will remove the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Resolves #2761
Description
Integrates NVlab's ꟻLIP for image comparison, using their various weighted histogram methods. This feels soooo much more stable, thresholds aren't insanity, and new devices seem to consistently fall under threshold.
I also fixed up some other issues with the tests.
Testing
I ran the tests on all of my machines' cards and they all pass.