Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation comments for multi_draw_*_indirect_count #3694

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

pudnax
Copy link
Contributor

@pudnax pudnax commented Apr 15, 2023

Fixes typo in the documentation in two methods multi_draw_indirect_count and multi_draw_indexed_indirect_count for RenderPass struct.

The indirect buffer must be long enough to account for max_count draws, however only count will draws will be read. If count is greater than max_count, max_count will be used.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • [ ] Add change to CHANGELOG.md. See simple instructions inside file.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will will will will

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) April 15, 2023 18:02
@cwfitzgerald cwfitzgerald merged commit 562ad0d into gfx-rs:trunk Apr 15, 2023
@pudnax pudnax deleted the indirect-count-docs branch April 16, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants