Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually implement traits on wgpu::Id #3630

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

TheOnlyMrCat
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
In #3575, I neglected the fact that #[derive(Trait)] for built-in traits puts a T: Trait bound on wgpu::Id. This is certainly unwanted, so I've replaced the derive macros with the equivalent manual implementations.

Testing
Tested on my own code which relies upon these traits being implemented for concrete T

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 47a887c into gfx-rs:trunk Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants