Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of bytes_per_row and rows_per_image #3529

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Change type of bytes_per_row and rows_per_image #3529

merged 2 commits into from
Mar 6, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 24, 2023

Change type of bytes_per_row and rows_per_image (members of ImageDataLayout) from Option<NonZeroU32> to Option<u32>.

Similar to #3445.

@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Feb 24, 2023
@teoxoy teoxoy requested a review from crowlKats as a code owner February 24, 2023 18:32
cwfitzgerald
cwfitzgerald approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank goodness!

@teoxoy
change type of bytes_per_row and rows_per_image (members of `Imag…
a369295 
…eDataLayout`) from `Option<NonZeroU32>` to `Option<u32>`
crowlKats
crowlKats approved these changes Mar 5, 2023
View reviewed changes
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deno part LGTM

@cwfitzgerald cwfitzgerald merged commit cf40e64 into gfx-rs:master Mar 6, 2023
@teoxoy teoxoy deleted the update-types branch March 7, 2023 12:39
@KunoSayo KunoSayo mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
WebGPU Specification V1
Development

Successfully merging this pull request may close these issues.
3 participants
@teoxoy @cwfitzgerald @crowlKats