enable debug extension on emscripten #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
requested changes
Feb 22, 2023
|
nice. don't forget to update the wiki too 👍 |
|
The wiki is publicly editable :) |
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Mar 9, 2023
* enable debug extension on emscripten * update changelog * extract emscripten stuff into a separate module * use unmasked queries on w-u-u, and only enable extension on emscripten * fix docs
cwfitzgerald
pushed a commit
that referenced
this pull request
Mar 9, 2023
* enable debug extension on emscripten * update changelog * extract emscripten stuff into a separate module * use unmasked queries on w-u-u, and only enable extension on emscripten * fix docs
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
#3245
Description
we check if
WEBGL_debug_renderer_infoextension is available on emscripten and if it is, we query for unmasked vendor/renderer strings.but on webgl, we need to enable the extension before using it. but emscripten avoids enabling this particular extension by default.
so, we use emscripten's extern functions defined in https://github.com/emscripten-core/emscripten/blob/4d864df0a57024d667e8db171aab2c3385d04c30/system/include/emscripten/html5_webgl.h#L61 to manually enable the extension if it is found on emscripten target. or fallback to vendor/renderer constants instead of the unmasked variants.
Testing
wgpu-hal's gles html example used for testing.
I believe the wiki needs to be updated https://github.com/gfx-rs/wgpu/wiki/Running-on-the-web-with-Emscripten